Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Server Code Submissions

Reply
 
Thread Tools Display Modes
  #1  
Old 02-25-2010, 08:27 PM
trevius's Avatar
trevius
Developer
 
Join Date: Aug 2006
Location: USA
Posts: 5,946
Default

Cool, the haste fix looks good now. I don't really know a ton about new pet stuff on live, and didn't look into your code enough to really tell if charmed pets would be affected or not. I didn't think it would be an issue, but that was the only possibility of an exploit I could think of from your changes. Sounds like it should be just fine. My concern was if people gave a charmed pet an item with charges and then broke charm and killed it, the item might have full charges again. Definitely sounds like that is not the case, which is good.

And yeah, the main reason I don't want to add this myself is because I am not the most knowledgeable about how pets should work. I also am always cautious when messing with the size of the player profile or extended profile. It looks like the SQL you submitted should keep there from being any issues, but those blobs can definitely cause major headaches if something goes wrong. Also, I think you are right that KLS is planning to do work on this for her Spells branch, so it may be best to see what she gets done and go from there.
__________________
Trevazar/Trevius Owner of: Storm Haven
Everquest Emulator FAQ (Frequently Asked Questions) - Read It!
Reply With Quote
  #2  
Old 02-25-2010, 09:00 PM
KLS
Administrator
 
Join Date: Sep 2006
Posts: 1,348
Default

My only concern is the pets that exist on the server will be corrupted by simply changing the blob structure like that.
Reply With Quote
  #3  
Old 02-26-2010, 12:41 AM
bad_captain
Developer
 
Join Date: Feb 2009
Location: Cincinnati, OH
Posts: 512
Default

Wouldn't the extprofile be okay with the supplied sql code, if it were run at the same time as the patch applied? I think the regular player profile would need the same type of sql code run (not expanding it, but just shifting the suspended minion struct back a little), and I tried to write it, but I came to the issue that the listed offsets in the the comments are incorrect, and I couldn't find the second error that gets the numbers back in line. The first was around 360 or so if I remember correctly. I didn't want to really mess something up, so that's why I posted on it in another thread a couple of days ago pointing out that the listed offsets were incorrect.

Anyway, I wanted to get this out there for anyone who wanted to play around with it, and now back to work on the bot group healing.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 05:05 PM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3