Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Server Code Submissions

Reply
 
Thread Tools Display Modes
  #1  
Old 09-11-2010, 07:30 AM
joligario's Avatar
joligario
Developer
 
Join Date: Mar 2003
Posts: 1,498
Default

Excellent work! Cheers!
Reply With Quote
  #2  
Old 09-12-2010, 01:11 PM
Vanicae
Fire Beetle
 
Join Date: May 2010
Posts: 9
Default

This actually needs an addition ASAP. Gaeorn helped identify the problem yesterday and has this fix, but didn't get around to adding it yet.

I didn't verify the return was valid and World doesn't like null pointers =/

I've been unable to reproduce the conditions that would cause this to not return a valid client, it seems to have happened yesterday with some larger guilds, which isn't easily testable on a personal test server.

Code:
Index: clientlist.cpp 
=================================================================== 
--- clientlist.cpp   (revision 1655) 
+++ clientlist.cpp   (working copy) 
@@ -407,6 +407,10 @@ 
  
    uint32 Count = 0; 
    ClientListEntry* from = this->FindCLEByCharacterID(FromID); 
+   if (!from) { 
+      _log(WORLD__CLIENT_ERR,"Invalid client. FromID=%i GuildID=%i", FromID, GuildID); 
+      return; 
+   } 
    LinkedListIterator<ClientListEntry*> Iterator(clientlist); 
  
    Iterator.Reset();

Sorry!
Van
Reply With Quote
  #3  
Old 09-12-2010, 02:04 PM
Derision
Developer
 
Join Date: Feb 2004
Location: UK
Posts: 1,540
Default

No problem Fix is in Rev1659. Thanks.
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 08:48 PM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3