Having Issues with EVENT_GROUP_CHANGE

[bad_captain]

Okay, did a little more testing. All sql updates sourced in at least as far back as Rev 1510.

This only seems to come up when I am using botgroups. If I only have bots in my group, no problem. If I have bots grouped outside mine, I get crashes on zone exit. I will take a look at my db schema for botgroups, but I'm pretty sure nothing has changed with them recently, as things were working at least around Rev 1721. (I may have been mistaken that things were working as of Rev 1751, as I was having server crashes due to hardware problems, and may have never made it to zone out. I will have to check my logs to see if there's anything in there.

So, anyway, my issue appears to be botgroups and the EVENT_GROUP_CHANGE.

[Derision]

The crash appears to be due to the fact that when Mob::SetGrouped is called for a bot, it casts the Mob to a Client before calling Parser::Event, which is obviously not valid.

The quick fix would appear to be only call EVENT_GROUP_CHANGE for clients:

Index: mob.cpp
===================================================================
--- mob.cpp     (revision 1786)
+++ mob.cpp     (working copy)
@@ -4125,7 +4125,9 @@
                israidgrouped = false;
        }
        isgrouped = v;
-       parse->Event(EVENT_GROUP_CHANGE, 0, "", (NPC*)NULL, this->CastToClient());
+
+       if(IsClient())
+               parse->Event(EVENT_GROUP_CHANGE, 0, "", (NPC*)NULL, this);
 }

 void Mob::SetRaidGrouped(bool v)
@@ -4135,7 +4137,9 @@
                isgrouped = false;
        }
        israidgrouped = v;
-       parse->Event(EVENT_GROUP_CHANGE, 0, "", (NPC*)NULL, this->CastToClient());
+
+       if(IsClient())
+               parse->Event(EVENT_GROUP_CHANGE, 0, "", (NPC*)NULL, this);
 }

 sint16 Mob::GetCriticalChanceBonus(int16 skill, bool aa_bonus)