Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Bots

Development::Bots Forum for bots.

Reply
 
Thread Tools Display Modes
  #1  
Old 01-03-2011, 06:44 PM
Fasthand
Fire Beetle
 
Join Date: Dec 2010
Location: Montreal
Posts: 29
Default

Well guess i should not be posting anything that look suspicious, i feel i would get the answer that the code is working perfectly.

Im just reading code for like 3 minutes and i see like 3 things that peek out my attention.

Im not here to bitch at coding or point out fingers, i just want to get it fix for the benefits of the community.

is the mana_regen_rate means to be a multiplier on how fast the bot was suppose to regen their mana, cause if it so ... why dividing it... ie: if i set variable to 5.0 i was thinking it should be 5x faster and not 1/5 ... you guys divide at the end instead of multiplying. (i dont have raw data on all the variables so i might be wrong, but that looks wrongs).

Code:
regen = (regen * RuleI(Character, ManaRegenMultiplier)) / 100;
float mana_regen_rate = RuleR(Bots, BotManaRegen);
if(mana_regen_rate < 1.0f)
   mana_regen_rate = 1.0f;
regen = regen / mana_regen_rate; <==== thats look weird 
SetMana(GetMana() + regen);
Yes i know code is working ... and working as intended ... now can we drop out that anemosity i feel ... or i should just fix things on my side and forget to keep your guys up to date?

Fasthand aka
s0rCieR MQ2 plugin grand daddy!
Reply With Quote
  #2  
Old 01-03-2011, 08:56 PM
Caryatis
Dragon
 
Join Date: May 2009
Location: Milky Way
Posts: 539
Default

ten characters

Last edited by Secrets; 01-05-2011 at 12:01 PM..
Reply With Quote
  #3  
Old 01-03-2011, 11:20 PM
Fasthand
Fire Beetle
 
Join Date: Dec 2010
Location: Montreal
Posts: 29
Default

ten characters

Last edited by Secrets; 01-05-2011 at 12:01 PM..
Reply With Quote
  #4  
Old 01-03-2011, 11:34 PM
Caryatis
Dragon
 
Join Date: May 2009
Location: Milky Way
Posts: 539
Default

ten characters

Last edited by Secrets; 01-05-2011 at 12:01 PM..
Reply With Quote
  #5  
Old 01-05-2011, 11:59 AM
Secrets's Avatar
Secrets
Demi-God
 
Join Date: May 2007
Location: b
Posts: 1,449
Default

keep this on topic. I removed the offending posts. Cayartis, you should know better.
Reply With Quote
  #6  
Old 01-04-2011, 10:44 AM
trevius's Avatar
trevius
Developer
 
Join Date: Aug 2006
Location: USA
Posts: 5,946
Default

@Caryatis

Quote:
Originally Posted by Caryatis View Post
something about playing a different game that secrets removed due to it being dumb
It is the "or play a different game" part that I work so hard to prevent. We want more players, devs, and server admins in this community, not less. The more the community grows, the better, as long as we can handle support for the growing numbers.

Sure, most of the information is out there ...somewhere. But, it isn't always clear, current, or easy to find. Starting fresh into an established community like this can be a bit overwhelming. I really wish we had much better starting documentation that could get people running with many less questions and issues. I wrote the FAQ page to help with some general/common stuff, but it could definitely be expanded. It would be really nice if we had really good and consistently updated server startup guides too. It isn't an easy task to keep all documentation current, though.

I don't really classify most of your posts as flames or trolling really. I see them more as someone with little patience for people who ask questions that should be easy enough to answer if they looked around a bit more (which is how I think you see yourself). I just prefer to go easy on people as long as they don't get out of hand with asking simple questions that should be easy enough to find the answers on their own. I would rather not respond at all, than respond with something that is most likely just going to piss them off.

@Fasthand

I realize that the community here may not be what you are used to. In general, I think most people are nice and helpful. The problem is due to the small size of the people who are involved and active, a response may be very slow or may never happen at all.

Also, just posting bits of code that don't look right is most likely not going to get an in-depth explanation to why it is that way. Most stuff works as it is, so there is little reason to mess with it and risk breaking something unless there is a clear issue and solution.

Even if you have many years of experience with C++ and are familiar with the MQ2 side of EQ-related code, the source for EQEmu is completely different and has many more pieces to it and can be very complex and hard to comprehend. Your best bet would be to take a while to get more familiar with the source. Also, before posting changes, it is best to test the code out yourself and verify there is a real problem and that your solution resolves the issue. Everyone on this project is a volunteer and most have little time to look into random snippets that get posted. If you do your research and testing and can post changes with good explanation of why the change is needed and the testing that was done to verify it was needed and that the change resolves them, then you will be much more likely to get a more helpful response. Even still, since we are busy, it can take a while for devs to get to people's submissions if they are complex, or if they are out of their area of expertise. We do try to get most submissions committed as long as we have the time and as long as they look like good and needed changes.

If you feel like you are able to help out the project and community as a whole, and are willing, then feel free to. We are always glad to see new skilled developers that can really contribute to the project. But, also keep in mind that this project requires a fair amount of patience. It takes lots of time to get a good grasp on everything and also can take time to get good responses on anything.
__________________
Trevazar/Trevius Owner of: Storm Haven
Everquest Emulator FAQ (Frequently Asked Questions) - Read It!

Last edited by Secrets; 01-05-2011 at 12:02 PM..
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 11:57 AM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3