Host of the Elements patch

[Caryatis]

I dont remember this function from live at all, always was earth elementals as far as I remember.

Besides that though...

//Magician AA Host of the Elements -- Manbear (blmille2)

I understand you want some credit for it but signing a 10 line diff is alittle over the top lol. Personally I think its unsightly to have people signing shit left and right, but thats just me.

[trevius]

Originally Posted by Caryatis

I understand you want some credit for it but signing a 10 line diff is alittle over the top lol. Personally I think its unsightly to have people signing shit left and right, but thats just me.

Not a big deal, but yeah; since we have the SVN changelog as well as the changelog.txt file, there is no need to add names to source updates. I have actually been removing names from notes like that as I see them near code I am working on. If we want to know who made what change, it is easy enough to find it on the SVN. You will still get credit in the changelog.txt as well as in the SVN rev note if the change gets added.

[blmille2]

Originally Posted by Caryatis

I dont remember this function from live at all, always was earth elementals as far as I remember.

Besides that though...


I understand you want some credit for it but signing a 10 line diff is alittle over the top lol. Personally I think its unsightly to have people signing shit left and right, but thats just me.

I was following by example.


Other than that, I got the request from one of the devs. I can look into it if the instructions weren't exactly correct.

[blmille2]

Make sure to start with a fresh SVN checkout, as the code before has been removed.

Index: zone/AA.cpp
===================================================================
--- zone/AA.cpp (revision 1873)
+++ zone/AA.cpp (working copy)
@@ -609,6 +609,23 @@
                        npc_dup = new NPCType;
                        memcpy(npc_dup, made_npc, sizeof(NPCType));
                }
+    // Host of the Elements cosmetic code
+    switch(spell_id){
+      case 3288: // Host of the Elements, Rank 3
+        npc_dup->race = 75;
+        npc_dup->texture = MakeRandomInt(0,3); // Earth, Fire, Water, Air
+        break;
+      case 3287:// Host of the Elements, Rank 2
+        npc_dup->race = 75;
+        npc_dup->texture = MakeRandomInt(0,1); // Earth, Fire
+        break;
+      case 3286:// Host of the Elements, Rank 1
+        npc_dup->race = 75;
+        npc_dup->texture = 0; // Earth
+        break;
+      default:
+        break;
+    }

                NPC* npca = new NPC(
                                (npc_dup!=NULL)?npc_dup:npc_type,       //make sure we give the NPC the correct data pointer