Simulated AE Rampage Script

[joligario]

Just a quick glance, but I would assume it has something to do with hardcoding 0 and 2000 rather than getting a true client count. Haven't done it in a while, but is there truly a client with ID of 0? Another thing to think of is what happens when you get beyond the actual list of clients.

[chrsschb]

Originally Posted by joligario

Just a quick glance, but I would assume it has something to do with hardcoding 0 and 2000 rather than getting a true client count. Haven't done it in a while, but is there truly a client with ID of 0? Another thing to think of is what happens when you get beyond the actual list of clients.

Not sure why that would cause any issue, it never did before (and is how it was written by Kayen).

[lerxst2112]

Something like this might work, and it'd be more efficient since it's not going to try and retrieve 2000 clients.

my @clientlist = $entity_list->GetClientList();
foreach $ent (@clientlist)
{
    my $x = $npc->GetX();
    my $y = $npc->GetY();
    my $z = $npc->GetZ();
    my $distanceCHK = $ent->CalculateDistance($x, $y, $z);
    my $PLTarget = $npc->GetTarget();
    my $TargID = $PLTarget->GetID();
    my $ClID = $ent->GetID();
    my $RampDamageVar = (int(rand($DamageVar ))) + (int($ShieldMinDam));
    if (($distanceCHK <= 2000) && ($TargID != $ClID))
    {
        $ent->Damage($npc, $RampDamageVar, 7477, 1, true, -1, false);
        $ent->Message(13, "$cmname hits YOU for $RampDamageVar points of damage!");
    }
}

[chrsschb]

Originally Posted by lerxst2112

Something like this might work, and it'd be more efficient since it's not going to try and retrieve 2000 clients.

my @clientlist = $entity_list->GetClientList();
foreach $ent (@clientlist)
{
    my $x = $npc->GetX();
    my $y = $npc->GetY();
    my $z = $npc->GetZ();
    my $distanceCHK = $ent->CalculateDistance($x, $y, $z);
    my $PLTarget = $npc->GetTarget();
    my $TargID = $PLTarget->GetID();
    my $ClID = $ent->GetID();
    my $RampDamageVar = (int(rand($DamageVar ))) + (int($ShieldMinDam));
    if (($distanceCHK <= 2000) && ($TargID != $ClID))
    {
        $ent->Damage($npc, $RampDamageVar, 7477, 1, true, -1, false);
        $ent->Message(13, "$cmname hits YOU for $RampDamageVar points of damage!");
    }
}

Like this? (still doesn't get to the damage portion)

sub EVENT_TIMER
   {
   
   if ($timer eq "rampage")
      {
      quest::stoptimer("rampage");
      my $TimeRA = quest::ChooseRandom(15);
      quest::settimer("getclients", $TimeRA);
      }

	if ($timer eq "getclients")
		{
		$cmname = $npc->GetCleanName();
		my $MaxDam = $npc->GetMaxDMG();
		my $ShieldMaxDam = ($MaxDam * .80);
		my $ShieldMinDam = $ShieldMaxDam / 2;
		my $DamageVar = ($ShieldMaxDam - $ShieldMinDam);
		$entity_list->MessageClose($npc, 1, 2000, 13, "$cmname SLAMS his hammer into the ground!");
		my @clientlist = $entity_list->GetClientList();
		foreach $ent (@clientlist) 
			{
			my $x = $npc->GetX();
			my $y = $npc->GetY();
			my $z = $npc->GetZ();
			my $distanceCHK = $ent->CalculateDistance($x, $y, $z);
			my $PLTarget = $npc->GetTarget();
			my $TargID = $PLTarget->GetID();
			my $ClID = $ent->GetID();
			my $RampDamageVar = (int(rand($DamageVar ))) + (int($ShieldMinDam));
			if (($distanceCHK <= 2000) && ($TargID != $ClID))
				{
				$ent->Damage($npc, $RampDamageVar, 7477, 1, true, -1, false);
				$ent->Message(13, "$cmname hits YOU for $RampDamageVar points of damage!");
				}
			}	
		}
   }