Null Spell Editor

[Drakiyth]

How in the world do you get these two things to work as a buff?
8.0 is the mod I want to give the bard for a limited time and 51 is All Bard Instrument mods. All the tests I've tried haven't shown any improvements when I check out my test bard in #mystats.

Also question: Is there any place/guide that has the right way to make these spell effects work? Where to put numbers etc?




Checked the spell_effects.cpp and it says it's handled elsewhere. ???

Nothing on either of these in spells.cpp either.

[Drakiyth]

Anybody know how to get bard instruments going through here? I've tried.


AddIntrumentMod - 12, 41, 49, 54, 70 on min and special. - NOTHING
AllInstrumentMod - 12, 41, 49, 54, 70 on min and special. - NOTHING


Is this just broken? I notice on live they use the spell effects for their instrument mods. I need it for the Mystical Artist's 1.0 weapon buff.

[Caryatis]

I suppose you never checked the spdat.h file(you know where all this is defined):

#define SE_AddInstrumentMod				260 // *not implemented

and from bonuses.cpp:

case SE_AllInstrumentMod:
	{
	if(effect_value > newbon->singingMod)
		newbon->singingMod = effect_value;
	if(effect_value > newbon->brassMod)
		newbon->brassMod = effect_value;
	if(effect_value > newbon->percussionMod)
		newbon->percussionMod = effect_value;
	if(effect_value > newbon->windMod)
		newbon->windMod = effect_value;
	if(effect_value > newbon->stringedMod)
		newbon->stringedMod = effect_value;
	break;
	}

ie you don't need to use any other field but the effect_base_valueXX.

You say live uses spell effects to boost spells, yet you dont try to copy any live spells?

For example, if you had checked out Amplification you would have noticed it uses an entirely seperate spell effect(118 ) to boost the singing skill.

Last but not least, your testing method is quite lazy. All you did was open mystats and then get disappointed. Lets look at the mystats code since that takes like 5 seconds:

std::string bard_info = "";
	if(GetClass() == BARD) {
		bard_info = indP + "Singing: " + itoa(GetSingMod()) + "<br>" +
					indP + "Brass: " + itoa(GetBrassMod()) + "<br>" +
					indP + "String: " + itoa(GetStringMod()) + "<br>" +
					indP + "Percussion: " + itoa(GetPercMod()) + "<br>" +
					indP + "Wind: " + itoa(GetWindMod()) + "<br>";
	}

The important bits are GetXXXMod, lets go deeper:

inline virtual sint16	GetStringMod()		const { return itembonuses.stringedMod; }

So to recap, you create a spellbonus to songs, you then check that with a function that only returns the itembonuses and thus you assume the effects are broken and post twice about it.

Searching... not just for the forums!

[Drakiyth]

Hey Caryatis,

Thanks for your help, even though you were a total douche about it.

Amplification is considered "SINGING SKILL" which is not what I asked for - There are currently no ADDINSTRUMENTMOD OR ALLINSTRUMENTMOD effects in the spell data base. But I'll try it with just the base value without the special and see if it works. Did I piss in your cheerios or something, or do you have a vendetta against me because you're acting like a real tool towards me. If you have something to say, I'm all for talking to you one on one.

[Optimus]

Booo.... I liked the first response better. He deserved it.

[Drakiyth]

Gotta try and stay a bit professional and not lose my head over trolls. Honestly though, if anybody did talk to me like that in person I would break their jaw. He acted like a total asshole, no doubt about that. That didn't work, AllInstrumentMod does not work at all and if it does please tell me what I'm doing wrong and prove me wrong. I would love to be proven wrong on this issue.

[Caryatis]

Honestly though, if anybody did talk to me like that in person I would break their jaw.

I love when people say this, I know in your head you think this sounds good but I wish you could see how others view you after saying that. Ill take a guess though...

Number of jaws you have broken in your life: 0
Number of assholes you have met in real life: Not 0

That didn't work, AllInstrumentMod does not work at all

Prove it. What did you do besides typing #mystats?