check_hasitem issue or just bad Perl Code

[sorvani]

You should also take the hail check out of every line and simply wrap all the hand in checks in a single is hail like Drajor did in the loop example.

  if($text=~/hail/i) {
         if(plugin::check_hasitem($client, 132535)) {
       quest::say("Hail, $name! Bring me your old charm and a Aviak Charm and I will upgrade your Charm");
      } elsif(plugin::check_hasitem($client, 132538)) {
        etc
    }
  } #end hail if block
} #end EVENT_SAY

additionally, you are using the return items poorly. it should be outside of ANY logic block at the end of the sub. There is no need for it to be in a logic check. as all the check_item stuff removes from the hash as it processes.

sub EVENT_ITEM {
 if (some logic) {
    stuff
 } elsif(some other logic) {
    other stuff
 } else {
    other other stuff
 }
 plugin::return_items
}

[Gaflack]

Thanks for the post sorvani.

I really appreciate that you took the time to not just say 'your code is lame' but to show where to improve. After 20+ years away from any coding any help is a blessing. There are lots of us trolls out here who learn tons from posts where you show a better way to do something.

I will redo my quest then see if it kills my clients before I make my other tests.

Thanks again,

Gaf