Random dynamic zone crashes

[lerxst2112]

Zone is shutting down and a string in NPCType is getting deleted in the NPCType destructor, but the memory it points to is bogus. I'd look for someone using memset on NPCType which is a no no since it's not a POD type. Anywhere you're tempted to use memset, use a default constructor instead, so much safer.

Did you compile for Debug specifically or RelWithDebInfo? Asserts and debug memory validation should be turned off in a release build which would keep the error message from popping up. It might still crash on shutdown, but it would do so silently and not wedge the server with a bunch of stuck processes.

[fwaits]

Thanks for replying. I actually don't remember compiling with debug active to be honest, but I'm pretty new at this. At what step of building/compiling would that be defined and I'll go back through my steps and check for it? And for the record, this is a stock build of the emulator, not doing anything custom.

[fwaits]

I guess I mean is that defined during the CMake portion or the Visual Studio compile? Perhaps both? Any help is appreciated, thanks.

[KLS]

Thought this bug was fixed on the 18th.

[fwaits]

I think I built this a little before July 18th if that's the date you are referring to.

[KLS]

Aye that makes sense, this was a bug caused by the aforementioned memsets. I pushed a workaround to the bug to the source on the 18th that fixes the crash.