"Spell" Quest

[Fadedspirit]

First, why are you defining client in a client script?

$client-> literally works......


You're defining a NEW $client object with an uppercase C in Client, was this intentional? If so, why?


Also, why are you redining what $client is more than once?? Aside from the fact you don't have to do it, at all, you're doing it once in spell effects for no reason and then again for lifetap????

[Township EQ]

Originally Posted by Fadedspirit

First, why are you defining client in a client script?

$client-> literally works......


You're defining a NEW $client object with an uppercase C in Client, was this intentional? If so, why?


Also, why are you redining what $client is more than once?? Aside from the fact you don't have to do it, at all, you're doing it once in spell effects for no reason and then again for lifetap????

Someone I asked help with while it wasn't working gave me something to try and I just left it in there.. Either way, your post isn't very helpful.

[Akkadius]

Originally Posted by Fadedspirit

First, why are you defining client in a client script?

$client-> literally works......


You're defining a NEW $client object with an uppercase C in Client, was this intentional? If so, why?

First - Because it is not a client script - it's a spell script. $caster_id is the exported object of this trigger EVENT:

                case EVENT_SPELL_EFFECT_CLIENT:
		case EVENT_SPELL_EFFECT_NPC:
		case EVENT_SPELL_EFFECT_BUFF_TIC_CLIENT:
                case EVENT_SPELL_EFFECT_BUFF_TIC_NPC:
		{
			ExportVar(packagename.c_str(), "caster_id", extradata);
			break;
		}

Second - GetTarget() is a valid mob method

Third - He made a syntax error

sub EVENT_SPELL_EFFECT_CLIENT {
	my $client = $entity_list->GetClientByID($caster_id);
	my $ClientTarget = $Client->GetTarget();
	if($ClientTarget->IsNPC()) {	 
		TESTLIFETAP();
	}
}

Should be:

sub EVENT_SPELL_EFFECT_CLIENT {
	my $Client = $entity_list->GetClientByID($caster_id);
	my $ClientTarget = $Client->GetTarget();
	if($ClientTarget->IsNPC()) {	 
		TESTLIFETAP();
	}
}

You're making your own client object - since client is not implied you have to fetch it through the data that is exported to the sub.

There is no need to respond in such a way - he legitimately asked for help.

[Fadedspirit]

Originally Posted by Akkadius

First - Because it is not a client script - it's a spell script. $caster_id is the exported object of this trigger EVENT:

                case EVENT_SPELL_EFFECT_CLIENT:
		case EVENT_SPELL_EFFECT_NPC:
		case EVENT_SPELL_EFFECT_BUFF_TIC_CLIENT:
                case EVENT_SPELL_EFFECT_BUFF_TIC_NPC:
		{
			ExportVar(packagename.c_str(), "caster_id", extradata);
			break;
		}

Second - GetTarget() is a valid mob method

Third - He made a syntax error

sub EVENT_SPELL_EFFECT_CLIENT {
	my $client = $entity_list->GetClientByID($caster_id);
	my $ClientTarget = $Client->GetTarget();
	if($ClientTarget->IsNPC()) {	 
		TESTLIFETAP();
	}
}

Should be:

sub EVENT_SPELL_EFFECT_CLIENT {
	my $Client = $entity_list->GetClientByID($caster_id);
	my $ClientTarget = $Client->GetTarget();
	if($ClientTarget->IsNPC()) {	 
		TESTLIFETAP();
	}
}

You're making your own client object - since client is not implied you have to fetch it through the data that is exported to the sub.

There is no need to respond in such a way - he legitimately asked for help.

Sorry, didn't see it was a spell script.

Also, the way I replied wasn't any different than what many would reply. There are only a few people whom are actually nice when it comes to code . Doesn't excuse me, but just saying.

[Township EQ]

Originally Posted by Akkadius

First - Because it is not a client script - it's a spell script. $caster_id is the exported object of this trigger EVENT:

                case EVENT_SPELL_EFFECT_CLIENT:
		case EVENT_SPELL_EFFECT_NPC:
		case EVENT_SPELL_EFFECT_BUFF_TIC_CLIENT:
                case EVENT_SPELL_EFFECT_BUFF_TIC_NPC:
		{
			ExportVar(packagename.c_str(), "caster_id", extradata);
			break;
		}

Second - GetTarget() is a valid mob method

Third - He made a syntax error

sub EVENT_SPELL_EFFECT_CLIENT {
	my $client = $entity_list->GetClientByID($caster_id);
	my $ClientTarget = $Client->GetTarget();
	if($ClientTarget->IsNPC()) {	 
		TESTLIFETAP();
	}
}

Should be:

sub EVENT_SPELL_EFFECT_CLIENT {
	my $Client = $entity_list->GetClientByID($caster_id);
	my $ClientTarget = $Client->GetTarget();
	if($ClientTarget->IsNPC()) {	 
		TESTLIFETAP();
	}
}

You're making your own client object - since client is not implied you have to fetch it through the data that is exported to the sub.

There is no need to respond in such a way - he legitimately asked for help.

Fixed the syntax error.

Originally Posted by Fadedspirit

Sorry, didn't see it was a spell script.

Also, the way I replied wasn't any different than what many would reply. There are only a few people whom are actually nice when it comes to code . Doesn't excuse me, but just saying.

And your post seemed pretty rude.. I've come across many people in this community who can be knowledgeable and nice at the same time. I am posting in the correct forum, which is a support forum. Either way, I just want to get this to work. I'm new at this, sorry for the syntax error.