Remove NPC titles (lastnames)

eqrage · #1 07-03-2016, 06:02 PM

Is there a way to remove ALL NPC titles? A quick database update gets rid of most of them, but a few are left ("GM Necromancer, GM Paladin"... etc).

A quick look in mob.cpp leaves me under the impression that there's no way to disable these particular titles to be set.

Did I miss anything? Can I submit a request for such a .. variable I suppose? Can I submit a patch?

I know it's a lot of questions.

I'm trying to make a classic server (ie: locked in Classic) and obviously NPC titles aren't classic.

I'd also like to avoid forking the source code, if at all possible. Hence the patch submission question.

Thanks.

**Uleat** · #2 07-03-2016, 06:28 PM

Pretty sure what you're looking for is here: https://github.com/EQEmu/Server/blob...e/mob.cpp#L904

I don't see a rule implemented to disable that behavior.

eqrage · #3 07-03-2016, 06:38 PM

Absolutely, this is the code I was referring to.

How should I proceed? Fork the code, or submit a request for that feature? Maybe even submit a patch? I have no prior EQEmu development experience, but willing to acquire some.

**Uleat** · #4 07-03-2016, 07:06 PM

I just pushed a rule-based option for that.

Pull in the latest code and give that a try - lemme know if that's what you're looking for.

EDIT: Don't forget to set the rule to false in your case..

eqrage · #5 07-04-2016, 05:35 AM

Quote:

Originally Posted by Uleat

I just pushed a rule-based option for that.

Pull in the latest code and give that a try - lemme know if that's what you're looking for.

EDIT: Don't forget to set the rule to false in your case..

Holy cow man, was this already scheduled and me asking was just a coincidence, or did you actually do it just because I asked?

Because if it's the latter, I kinda wanna french kiss you right now.

eqrage · #6 07-04-2016, 05:36 AM

Going to try in a few hours.

eqrage · #7 07-04-2016, 10:11 AM

Works perfectly, thanks.

**Uleat** · #8 07-04-2016, 02:47 PM

I'll pass on the kiss..but, you're welcome

(That was a simple - and useful - request, so I went ahead and implemented it.)

eqrage · #9 07-05-2016, 03:59 AM

Actually, I stand corrected. It works on vanilla Titanium but not on the P99-modified Titanium - still getting the NPC lastnames.

A grep through mob.cpp shows that there are two different places where 'GM Necro' and such are generated, and your patch only takes care of one.

Mind correcting this?

Thanks in advance.

eqrage · #10 07-05-2016, 05:16 AM

It's actually even wierder than that.

Logged in on the P99 Titanium client, went to Noxhil V`Sek (GM necro in neriakc).

No title. #repop'ed the zone, he repops with title. #repop, again, title again.

Go figure.

**Uleat** · #11 07-05-2016, 03:29 PM

Quote:

Logged in on the P99 Titanium client, went to Noxhil V`Sek (GM necro in neriakc).

No title. #repop'ed the zone, he repops with title. #repop, again, title again.

I think that's your answer

Initial zone-in and #repop use two different handlers.

I pushed a change with the rule in that second handler (- something I totally missed the first time...)

This issue shouldn't be affected by the p99 changes.

But, if you do eventually run across something that is a result of those mods, that would be something that we can't provide support for since that client is not
supported by EQEmu. (Same as with MQ2 issues.)

EDIT: There are some other issues that can be seen with using #repop. The appearance of Monk GM trainers in qeynos, for instance.

eqrage · #12 07-05-2016, 03:44 PM

Thanks.

I was only referring to P99 as a potential hint for tracking down the issue.