Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Server Code Submissions

Reply
 
Thread Tools Display Modes
  #1  
Old 08-12-2012, 05:15 PM
demonstar55
Demi-God
 
Join Date: Apr 2008
Location: MA
Posts: 1,165
Default COMMITTED: Damage Shield EXP fix

Currently the damage dealt via a damage shield factors into who gets experience. This is not how it functions on live.

Proof: http://www.magecompendium.com/pets-library.html#petexp and this post on Alla also mentions this fact in the "pincushioning" part http://everquest.allakhazam.com/foru...73098101489300

Code:
Index: attack.cpp
===================================================================
--- attack.cpp  (revision 2183)
+++ attack.cpp  (working copy)
@@ -3241,7 +3241,8 @@

        if(attacker){
                if(attacker->IsClient()){
-                       if(!attacker->CastToClient()->GetFeigned())
+                       // Damage shield damage shouldn't count towards who gets EXP
+                       if(!attacker->CastToClient()->GetFeigned() && !FromDamageShield)
                                AddToHateList(attacker, 0, damage, true, false, iBuffTic);
                }
                else

Last edited by cavedude; 09-13-2012 at 01:46 PM..
Reply With Quote
  #2  
Old 09-10-2012, 12:30 PM
cavedude's Avatar
cavedude
The PEQ Dude
 
Join Date: Apr 2003
Location: -
Posts: 1,988
Default

This was added to PEQ with the AA timer fix and I forgot to mention it.
Reply With Quote
  #3  
Old 09-10-2012, 07:18 PM
lerxst2112
Demi-God
 
Join Date: Aug 2010
Posts: 1,743
Default

That's gonna make people that are working on their RoA sad on EZ. Any chance of making it a rule to toggle the old behaviour on?
Reply With Quote
  #4  
Old 09-10-2012, 07:47 PM
cavedude's Avatar
cavedude
The PEQ Dude
 
Join Date: Apr 2003
Location: -
Posts: 1,988
Default

Of course, just an extra 2 lines.
Reply With Quote
  #5  
Old 09-10-2012, 09:08 PM
lerxst2112
Demi-God
 
Join Date: Aug 2010
Posts: 1,743
Default

I'm totally adding another gnome to my "Cavedude is the best!" shrine.
Reply With Quote
  #6  
Old 02-03-2013, 01:20 AM
quido
Fire Beetle
 
Join Date: Oct 2009
Posts: 16
Default

Damageshield should still add hate though, right? The damage just shouldn't count towards exp.
Reply With Quote
  #7  
Old 02-03-2013, 01:58 AM
demonstar55
Demi-God
 
Join Date: Apr 2008
Location: MA
Posts: 1,165
Default

No, and damage shields should cause no hate.
Reply With Quote
  #8  
Old 09-01-2013, 05:58 AM
knowom's Avatar
knowom
Discordant
 
Join Date: Jun 2006
Posts: 371
Default

Quote:
Originally Posted by demonstar55 View Post
No, and damage shields should cause no hate.
Says who? I get the exp thing and the concern, but actually if a toggle could also be implemented to make damage shields cause hate that would be a interesting feature.

Especially if you could even categorize it further by damage shields from items and damage shields from spells and adjust the aggro generation amounts caused.

Additionally same could be said with reverse damage shield which has often had limited usage though that could have fantastic use for a custom Paladin class with like a custom reverse damage shield spell proc buff for example and or Bard class for song spells.
Reply With Quote
  #9  
Old 09-01-2013, 11:12 AM
HeyJudd
Banned
 
Join Date: Aug 2013
Posts: 9
Default

This project is about recreating the EQ from Live, if you want crazy crap like that then edit the source yourself.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 08:59 PM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3