Hail is broken!!

[codyscafe7]

Whenever i hail someone on my server it never works. I look in my quests folder and find different people who have quests and when i go back into the game and hail them it doesnt work. For example here is a quest:

sub EVENT_SAY {
if($text=~/hail/i){
quest::say("Hello. Nice day, isn't it? It would be nicer if I didnt have to spend it killing these disgusting rodents that have infested town. Hey, I have an idea! How about you go kill some of them for me and collect four of their whiskers? I will reward you, of course.");
}
}

sub EVENT_ITEM {
if(plugin::check_handin(\%itemcount, 13071 => 4)){
quest::say("Here are you coins as promised. Have a nice day. I wish I could.");
quest::faction(212,5);
quest::faction(8,5);
quest::givecash(1,1,1,0);
}
}


and when i hail him in the game nothing happens.Ive tried hailing many npc's with quests but the same thing happens, nothing.
my plugins is in my eqemu folder and not my quest folder and ive searched and searched for answers but none work. Ive tried using angelox's database and project eq but the same thing still nothing. could someone please help me!!

[moydock]

are the names of your files in the 'Firstname_Lastname' format?

[image]

Perl scripts are setup in the following format: questdirectory/zoneshortname/npcid.qst

Depending on your database those npc ids may be different, I would make sure that the ID's that are in the database are the same as the id on the quest file.

[codyscafe7]

They are in the format quest\zonename\npc's first_lastname. Its weird because im doing everything right but the stupid hail button doesnt work.

[image]

I am looking in the source code for embparser.cpp

(Mean't to use .pl up above by the way)

I see quests/zone/npcid.pl but there is also a naming version as well fnw implemented with quests/zone/npcname

To get naming version you need the QUEST_SCRIPTS_BYNAME define in features.h to be on (looks like its on by default in 0.7.0 release).

It looks like the names have to be the same as the database minus any numbers, il tell you the top two line of this code says ( line 498 ):
//Father Nitwit's naming hack.
//untested on windows...
So you get to find out I guess

But, it by default checks for npcid.pl as well before it even searches for npcname.pl

[devn00b]

Lmao I decided to peak at the code myself...and its a joke.

 char tmpname[64];
           int count0 = 0;
           bool filefound = false;
           tmpf = fopen(filename.c_str(), "r");
           if(tmpf != NULL) {
                fclose(tmpf);
                filefound = true;
           }

WTF is tmpname doing there? its not even used.

or how about

        filename = "quests/";
                     filename += QUEST_TEMPLATES_DIRECTORY;
                     filename += "/";
                     filename += tmpname;
                     filename += ".pl";

Come on put that shit on one line. Talk about sloppy.

or hey here is some really great code

    tmpname[0] = 0;
           //if there is no file for the NPC's ID, try for the NPC's name
           if(! filefound) {
                //revert to just path
                filename = bnfilename;
                const NPCType *npct = database.GetNPCType(npcid);
                if(npct == NULL) {
 //LogFile->write(EQEMuLog::Debug, "     no npc type");
                     //revert and go on with life
                     filename += itoa(npcid);
                     filename += ".pl";
                     curmode = questByID;
                } else {
                     //trace out the ` characters, turn into -
 
                     int nlen = strlen(npct->name);
                     if(nlen < 64) {     //just to make sure
                          int r;
                          //this should get our NULL as well..
                          for(r = 0; r <= nlen; r++) {
                               tmpname[r] = npct->name[r];
 
                               //watch for 00 delimiter
                               if(tmpname[r] == '0') {
                                    count0++;
                                    if(count0 > 1) {     //second '0'
                                         //stop before previous 0
                                         tmpname[r-1] = '\0';
                                         break;
                                    }
                               } else {
                                    count0 = 0;
                               }
 
                               //rewrite ` to be more file name friendly
                               if(tmpname[r] == '`')
                                    tmpname[r] = '-';
 
                          }
                          filename += tmpname;
                          filename += ".pl";
                          curmode = questByName;
                     } else {
 //LogFile->write(EQEMuLog::Debug, "     namelen too long");
                          //revert and go on with life, again
                          filename += itoa(npcid);
                          filename += ".pl";
                          curmode = questByID;
                     }
                }

Wow you know if i did shit like that at work, id be fired on the spot. not only fired id be laughed out of the fucking building and shot.

You know back in the day we had a project leader that would inspect changes like this.

Wtf not tested on windows?! Whats that bs? It compiles SHIP IT! If your going to write code just for nix fork the project and release the code as "nix compile". My oh my how eqemu has degraded. I almost hate saying this, but where is hogie when ya need him.

[Lalolyen]

Originally Posted by image

Perl scripts are setup in the following format: questdirectory/zoneshortname/npcid.qst

Depending on your database those npc ids may be different, I would make sure that the ID's that are in the database are the same as the id on the quest file.

"questdirectory/zoneshortname/npcid.qst"

thought it was NPCNAME.pl? or NPCID.pl (if you want a specific spawn to do it) Least thats how I have mine setup...