Fix for tradeskill fail bug

[cavedude]

Sorry it took so long to get to this one.

I admit, it bothers me that items that return on success and failure we currently require 3 entries for them. Even nailing them down to 2 would be acceptable (component count + failure count) and product count. So in that way, I like your code. The big issue I have with this is it offers no backwards compatibility. tradeskill_recipe_entries is the only table I dread working with using scripts partially because of the "broken" system (most recipes are using the multiple entry system, but I do occasionally find a recipe that isn't and needs to be fixed) but mainly due to the exceptions, and inconsistencies. Our tradeskills originally were pulled in from scripts, so quite literally since I've been with PEQ I have found (and hand corrected) hundreds of errors (incorrect item entries dealing with items that have identical names, incorrect/missing trivial, no fail entries, items that had incorrect entries as to whether it was a component or product, etc) I am certain there are more, and they always seem to pop up when I am trying to run a script. We currently have 9,508 recipes in the db, and a rough estimate of 3,195 recipes are effected (I say rough estimate because of the inconsistencies above it could skew my results.) As much as I'd like this change in, I'd much rather have a backwards compatible system put in place so those 3,195 recipes can be corrected over time, and not in one dangerous swoop.

[ChaosSlayer]

I don't mean to rant or upset anyone.... but have anyone realised than 60% of original LIVE TS recipies are COMPLITE JUNK? Specialy on LIVE, specialy with current CVS Quest release DB.
Why? Cuase all those little lev 5-10 newbee armor quests you put in give WAY better armor than all the patchwork, leather, studded, banded, fine steel, etc etc etc that go up in requred crafting skill all way to 120+.
And by the time a player can actualy craft the first set of cultural armor - he most likely will be walking around either in ornate from lower PoP or in high end Kunark/Velius armor

Rememeber that LOTS of those recipies come from time when BRONZE was uber, and people did not got a full set untill lev 35+

In short: 3500 recipies thar people allreday put in by hand is sure a lot of work that is sad to go waste - but how much of that is actualy usefull?

PS: i did not meant to offend anyone

[Angelox]

It's a matter of preservation to me - if we keep everything in the database, and lets say some one really wants to make an Everquest that was Classic, they would already have what they needed in the PEQ database (few fixes to the source, and it would be all set). On the other hand, if we start judging what to keep and what to drop, even aside from my reason to keep it, we might regret this for other unknown reasons.
I still enjoy and am always thinking of the old zones and what I can do to better them. And If I were working recipes, it would be the old ones. In fact, I'm a "Knightly" fan, love all his fixes.

[So_1337]

To second Angelox's comment, it's much better to have a complete picture. That opens the door to anyone to do whatever customization they want without having to add what should've been there to start with. People have many more options to pick and choose when they have the full spectrum.

Also, huge thanks to Knightly for all his code. Some really, really good stuff lately.

[So_1337]

Fair enough, and no offense taken. I'm not much help around here, just try to encourage the work of others. Let me step outta here :)