Log in

View Full Version : Couple of doors questions


EvoZak
12-16-2008, 02:39 AM
#1 Looking at the doors code lately and I noticed something interesting. The Door_Struct has a uint8 typed for the doorId but the database (PEQ in this case) has doors with IDs past 255 (all in Mischief no less... hehe).

This may just be a database issue (doors table certainly doesn't restrict to byte sized ints) but there are no checks in the code on data length. Is it the system's default behavior for implicit casts to shave data without error? If that's the case it would explain why there is no errors being thrown.

#2 In the doors table the columns doorisopen and buffer seem to have no apparent use in the code anymore. Does anyone know of one, other than holding up the correct indexes for the code that fetches door data? What is/was buffer used for, in particular?

KLS
12-16-2008, 04:34 AM
I honestly have no idea why some of the door code still functions as there some serious casting issues somewhere, I haven't taken the time to see where because it works for now.

The field was probably used to store whether a door was open or not at one point but obviously outlived it's usefulness.

EvoZak
12-16-2008, 06:52 PM
Thanks for the reply. Yeah, it looks to me like doorisopen and buffer are both vestigial.