Error compiling rev 264 -- Linux

[Andrew80k]

I got this:

client.h:531: error: extra qualification ‘Client::’ on member ‘BotTradeSwapItem’
client.h:532: error: extra qualification ‘Client::’ on member ‘BotTradeAddItem’


I didn't see anything in the changes to make me think I need to do something different. Did I miss something?

[Angelox]

It just compiled ok with me - what version gcc are you using? (mine is 3.4.6)

[Angelox]

Anyway, since I'm going to bed, I think it's a gcc thing - you using gcc 4x?
in client.h lines 531, 532 ;
void Client::BotTradeSwapItem(NPC* bot, sint16 lootSlot, uint32 id, sint16 maxCharges, uint32 equipableSlots, bool swap = true);
void Client::BotTradeAddItem(uint32 id, sint16 maxCharges, uint32 equipableSlots, int16 lootSlot, NPC* bot, bool addToDb = true);


Replace with this;
void BotTradeSwapItem(NPC* bot, sint16 lootSlot, uint32 id, sint16 maxCharges, uint32 equipableSlots, bool swap = true);
void BotTradeAddItem(uint32 id, sint16 maxCharges, uint32 equipableSlots, int16 lootSlot, NPC* bot, bool addToDb = true);


It compiles both ways with me on my gcc 3x but I think the first one is a gcc -related problem, and I'm not sure the second is a correct fix either (you have to test if it compiles) .

[KLS]

It's not normal for function definitions to be like that anyway. I guess I gotta take an hour to look at submissions.

[Andrew80k]

thanks, Angelox. I'll give that a whirl.

[cubber]

Worked for me.

[Congdar]

that's my bad, i did a cut/paste and forgot to remove the Client:: part. I'll put in a fix.

[Congdar]

that's my bad, i did a cut/paste and forgot to remove the Client:: part. I'll put in a fix. Strange I didn't get an error... maybe a there was a warning but there are so many of those anyway.

[Andrew80k]

Thanks, Congdar. Works now!