Haste/Slow not working on NPCs

[KLS]

I think I've found the issue with this, slow / haste will not apply until the NPC changes targets.

void NPC::SetTarget(Mob* mob) {
	if(mob == target)		//dont bother if they are allready our target
		return;
	
	if (mob) {
		SetAttackTimer();
	} else {
		ranged_timer.Disable();
		attack_timer.Disable();
		attack_dw_timer.Disable();
	}
	target = mob;
}

the attack timer is only set when a NPC changes targets but a player's attack timer is set to change when he/she recalculates their item bonuses which happens whenever their calcbonuses goes off, which is why haste and slows seem to affect them perfectly but have hit and miss results with mobs.

Change Mob::CalcBonuses() to

void Mob::CalcBonuses()
{	
	CalcSpellBonuses(&spellbonuses);
	
	CalcMaxHP();
	CalcMaxMana();
	SetAttackTimer();
	rooted = FindType(SE_Root);
}

This issue isn't directly related to the first but I found it while testing the first out so.. if you snare something for more than 100% it will blink to you, this isn't an issue for anyone but a bard with a decent instrument mod(which was the character I was testing with). Using a 18 mod from singing short sword and Largo's Absonant Binding I'm able to get something like a -117% move speed, which then makes them run faster than the speed of light.

in Mob::_GetMovementSpeed()
find:

	int movemod = spellbonuses.movementspeed + itembonuses.movementspeed + mod;
	if (movemod != 0)
		speed_mod += float(movemod) / 100.0f;

and change it to

	int movemod = spellbonuses.movementspeed + itembonuses.movementspeed + mod;
	if(movemod < -85) //cap it at moving very very slow
		movemod = -85;

	if (movemod != 0)
		speed_mod += float(movemod) / 100.0f;

[Rhodan]

Was this noticed? I'm playing with 878 and none of my shaman's slows appear to work. I set up a level 50 shammy and cast the level 36(?) spell on a newbie mob - no change in attack speed.

[KLS]

This should be fixed, though I changed how haste was calculated the other day, I'll have a look at it tonight to make sure I didn't mess anything up.

[jeffpuff]

I can verify slow was fixed for a while, but stopped working as of .878 I have not tested .882 yet, the 11/02 post.

[KLS]

Doesn't work as of the latest source, looking for the cause atm. Haste works but slow doesn't.. never saw anything like this when I was first testing haste changes, obviously something was fubared in the process.

[Rhodan]

Gremlins, they sneak up on ya.