Compile problem with last rev update (1861)

[Huppy]

I tried this out twice, just to make sure, but after the last 1861 svn update,
(today) the compile is not building the zone app.
I did a successful compile on the previous update (1857) just to make sure
nothing special was happening on my end, but I was actually suprised to see
unsuccessful compile, as it has been going smooth with the updates for a long
time now
I am not sure what to look for in the build log, but if you need it posted here
I can do that, as well.

EDIT:

The only errors I seen while it was building zone, was the following in spells.cpp :

3>.\spells.cpp(146 : error C2661: 'Raid::GetGroup' : no overloaded function takes 0 arguments
3>.\spells.cpp(1480) : error C2661: 'Raid::GetGroup' : no overloaded function takes 0 arguments
3>.\spells.cpp(1492) : error C2661: 'Raid::GetGroup' : no overloaded function takes 0 arguments
3>.\spells.cpp(1504) : error C2661: 'Raid::GetGroup' : no overloaded function takes 0 arguments

I hope this helps.

[lerxst2112]

I would guess those need to change to something like this:

spells.cpp(1468): group_id_caster = GetRaid()->GetGroup(CastToClient());
spells.cpp(1480): group_id_caster = owner->GetRaid()->GetGroup(owner->CastToClient());
spells.cpp(1492): group_id_target = spell_target->GetRaid()->GetGroup(spell_target->CastToClient());
spells.cpp(1504): group_id_target = owner->GetRaid()->GetGroup(owner->CastToClient());

But I'm not sure if what GetGroup() returns is actually the right type of value. Hopefully the person that made the checkin will fix it, because it wouldn't compile for them either unless they changed something else and didn't check that in.

[Huppy]

Originally Posted by lerxst2112

I would guess those need to change to something like this:

spells.cpp(1468): group_id_caster = GetRaid()->GetGroup(CastToClient());
spells.cpp(1480): group_id_caster = owner->GetRaid()->GetGroup(owner->CastToClient());
spells.cpp(1492): group_id_target = spell_target->GetRaid()->GetGroup(spell_target->CastToClient());
spells.cpp(1504): group_id_target = owner->GetRaid()->GetGroup(owner->CastToClient());

But I'm not sure if what GetGroup() returns is actually the right type of value. Hopefully the person that made the checkin will fix it, because it wouldn't compile for them either unless they changed something else and didn't check that in.

I applied those changes to the lines you suggested and got a successful compile

EDIT: Distillate of Skinspikes issue was resolved with this update as well (see following post):

http://www.eqemulator.org/forums/sho...984#post196984

[c0ncrete]

I believe they should look like this:

1468: group_id_caster = GetRaid()->GetID();
1480: group_id_caster = owner->GetRaid()->GetID();
1492: group_id_target = spell_target->GetRaid()->GetID();
1504: group_id_target = owner->GetRaid()->GetID();

On second thought, those return raid IDs. That's just how they were in the previous build. What lerxst2112 suggested looks more accurate since it's supposed to be group IDs.