aggro radius

[gaeorn]

I've been noticing that lull/harmony effects do not appear to have the expected effect. In particular, the monk phantom line of disciplines do not appear to reduce assist range. Looking through code, I found this:

void EntityList::AIYellForHelp(Mob* sender, Mob* attacker) {
        _ZP(EntityList_AIYellForHelp);
        if(!sender || !attacker)
                return;
        if (sender->GetPrimaryFaction() == 0 )
                return; // well, if we dont have a faction set, we're gonna be indiff to everybody
        
        LinkedListIterator<NPC*> iterator(npc_list);
        
        for(iterator.Reset(); iterator.MoreElements(); iterator.Advance()) {
                NPC* mob = iterator.GetData();
                if(!mob){
                        continue;
                }
                float r = mob->GetAssistRange();
                r = r * r;

                if(sender == NULL)
                        return;

                if (
                        mob != sender
                        && mob != attacker
//                      && !mob->IsCorpse()
//                      && mob->IsAIControlled()
                        && mob->GetPrimaryFaction() != 0
                        && mob->DistNoRoot(*sender) <= r
                        && !mob->IsEngaged()
                        )
                {
                        //if they are in range, make sure we are not green...
                        //then jump in if they are our friend

Is there a reason we are squaring the assist range of a mob before deciding to assist?

[ChaosSlayerZ]

I think it could be related how we have a SINGLE value in npc_types for Personal Agro and for Assist range, while looking at spell file you clearly see that ALL lull type spells have as much as 3 diffirent properties - Lull, Frenzy range, and Harmony, each of which supposely does something diffirent...

[gaeorn]

Originally Posted by ChaosSlayerZ

I think it could be related how we have a SINGLE value in npc_types for Personal Agro and for Assist range, while looking at spell file you clearly see that ALL lull type spells have as much as 3 diffirent properties - Lull, Frenzy range, and Harmony, each of which supposely does something diffirent...

I don't understand what you are talking about. And not all spells have all 3 types of effects. The spells underlying the higher level monk phantom discs only have the harmony effect.

[ChaosSlayerZ]

Originally Posted by gaeorn

I don't understand what you are talking about. And not all spells have all 3 types of effects. The spells underlying the higher level monk phantom discs only have the harmony effect.

ok not all. but spells seem to diffirentiate between lull and frenzy radius, and in some cases harmony.

[gaeorn]

Although I still do not know why the range value in my first post was being squared, I believe I may have found out why the monk phantom disciplines don't work as desired. I'm using a version that is level 69, Phantom Cry. It only has the reaction radius effect (SE_Harmony), whereas lower level phantom discs have reaction radius, frenzy radius and lull effects.

According to this excerpt from the comments on this page:

That's exactly how all the monk pacify disc's work. They are designed to split mobs only.
However, you notice they are unresistable.
Any monk that gets this will already be well aware of how they work and how to use it.
The other classes had the biggest adjustment with their OoWar pacify spells since they removed the frenzy radius of all the OoWar pacify spells. That means that the aggro range of the mob is not affected. You can't pacify a mob and walk up near it - it will aggro. Since monks could only ever pacify one mob at a time, they never really got used to pacifying their way through groups of mobs.
It still works great for pulling, but it does take adjusting.

the reaction radius affects assist radius, not aggro radius. But looking at the code, that effect (SE_Harmony) is adjusting aggro radius (frenzy radius, SE_ChangeFrenzyRad, is adjusting assist radius). So from what I am reading, it appears these should actually be frenzy radius = aggro range and reaction radius = assist range. This would have been difficult to determine initially as the level 65 and lower pacify type spells all have both effects. In fact, according to an allakhazam search, all spells that have the frenzy radius effect also have the reaction radius effect.

[KLS]

The reason is to do the range check without the square root.

[ChaosSlayerZ]

KLS, but does Emu code actualy sees the diffirence between frenzy range and assist range?


Also could someone clearfy what then "harmony" value does, since these allready seem to cover both effects?