Fix for period (.) screwing up Identifiers ($name, etc)

krich · #1 06-03-2003, 08:22 AM

Yes, you could say that I'm on a bug hunt today. My goal, to kill all those little nitpicky bugs in the quest system that aggrevate me. :evil:

I'm a bit scared of this fix because of how simple it is. I can't find anything that it breaks, but perhaps some one else should eye this one closely.

The Problem:
When creating .qst files, putting a period (.) after an identifier will cause the quest to print NULL rather than the value of the identifier. For example this script will say NULL rather than your $name:

Quote:

EVENT_SAY {
if($1- =~ "Hail"){
SAY("Well met $name. I am Arianna Trueblade. Warlord of the Steel Warriors. I am personally in charge of all the training that our young warriors receive. I take pride in knowing that my teaching can help make the foundation of a Freeport Champion. If you are a [warrior] then we might just have something to talk about.")
}

The Fix:

Change line 1 of basic_functions.h from:

Code:

const char *notin = "() ,=!&amp;|&lt;>\"";

to:

Code:

const char *notin = "?.() ,=!&amp;|&lt;>\"";

Notice the period (.) at the beginning of the definition of notin.

Regards,

Krich

krich · #2 06-03-2003, 12:57 PM

Updated code above to include a Question Mark.

Enjoy,

Krich

Trumpcard · #3 06-06-2003, 02:59 AM

Merged this in to CVS, should be available there now. Please certify.

krich · #4 06-11-2003, 11:09 AM

Quote:

Originally Posted by Trumpcard

Merged this in to CVS, should be available there now. Please certify.

Confirmed. Lookin' good. :worship:

Regards,

krich