bug/cheat?

[trevius]

This might be a good thing to submit to the server code submissions section if you would be ok with it getting added to the source. Of course, IMO, it would be best if it only noted the incident into the hackers tables similar to how TheLieka's MQ detection does, and didn't ban the player. I don't think an autoban would get accepted in the source, but it just reporting any occurrences should be fine.

And as far as warp detection goes, that is already in the source from 1110 and later. You just have to make sure you add the correct table info and enable the rules for it to actually start working.

[spider661]

anyone know what this plugin is called?

i finally got a version of macroquest and want to test in on my server to see if this code worked..

please i promise im not one to go around to other servers using it just want to test it.

[rojadruid]

Originally Posted by trevius

This might be a good thing to submit to the server code submissions section if you would be ok with it getting added to the source. Of course, IMO, it would be best if it only noted the incident into the hackers tables similar to how TheLieka's MQ detection does, and didn't ban the player. I don't think an autoban would get accepted in the source, but it just reporting any occurrences should be fine.

And as far as warp detection goes, that is already in the source from 1110 and later. You just have to make sure you add the correct table info and enable the rules for it to actually start working.

If some one know how to code it the auto ban could be made into a rule.

[trevius]

I just added this code to my server and am compiling it now. I will test it out and if it works well, I will post it in the code submissions section unless ndnet has any issues with that. Of course, all credit goes to ndnet.

I edited mine so that it just returns false and logs it:

  /*------------------------------
  Added to prevent MQ2 
  exploitation of equipping 
  normally-unequippable items 
  with effects and clicking them
  for benefits. - ndnet
  ---------------------------------*/
  if(item_slot && IsClient() && slot == USE_ITEM_SPELL_SLOT)
  {
    ItemInst *itm = CastToClient()->GetInv().GetItem(item_slot);
    int bitmask = 1;
    bitmask = bitmask << (CastToClient()->GetClass() - 1);
    if( itm && itm->GetItem()->Classes != 65535 && (itm->GetItem()->Click.Type == ET_EquipClick) && !( itm->GetItem()->Classes & bitmask ) ){
      // They are casting a spell on an item that requires equipping but shouldn't let them equip it
      LogFile->write(EQEMuLog::Error, "HACKER: %s (account: %s) attempted to click an equip-only effect on item %s (id: %d) which they shouldn't be able to equip!", CastToClient()->GetCleanName(), CastToClient()->AccountName(), itm->GetItem()->Name, itm->GetItem()->ID);

      //CastToClient()->DeleteItemInInventory(inventory_slot,0,false);
      database.SetHackerFlag(CastToClient()->AccountName(), CastToClient()->GetCleanName(), "Clicking equip-only item with an invalid class");
      return(false);
    }
  }

I didn't want it auto-banning people, just in case it might be a little buggy. But, I do want to prevent it and to log it. I think that should work.

[trevius]

So far this seems to be working. For some reason, I equiped an item (mage epic) on my GM using the #equipitem and tried to cast, and it did interrupt the spell as it should, but it didn't write it to the hackers table. And, I don't see in the code where it makes GMs exempt from getting logged.

But, later I did get some logged from a player. I will have to confirm from someone with that pluggin that it is working properly and that there aren't any false positives. Though, it seems to be working well so far. No negative side and can only improve. I think this could probably be added directly into the source. I will test it a bit more and post it to the server code submission section and credit ndnet for it as long as there are no issues.

Nice to see 1 more hack resolved