Charmed mobs and the pet/group window and buffs

[Derision]

I'm feeling rather proud of myself this morning, I found the OP_Charm opcode for Titanium.

I read the Wiki pages that Trevius posted links to a couple of weeks back about using IDA to Disassemble the client
and find Opcodes.

E.g.: http://www.eqemulator.net/wiki/wikka...DevAsmRoutines

I don't know x86 assembler, however I have programmed in 6502 and IBM Mainframe assembly in years gone by, but I
still thought that finding opcodes through disassembly was 'out of my league'.

Well, I downloaded the free version of IDA, and disassembled the 6.2 client. Armed with the 6.2 Opcode, and with the
pointers to the dispatch routines and general methodology outlined in the wiki, I found the Charm routine in the 6.2
client.

I then disassembled the Titanium client and tried to find the same routine there, which I did. I then traced this back
up through the call tree and voila, for Titanium, OP_Charm=0x12e5. Just change this in your patch_Titanium.conf on the
server and restart it.

[MNWatchdog]

Good job fellow old coder. Although I got out of programming some 20 years ago, I too did a fair amount of 6502 on PETs, C64s, VIC 20s of all things. Also, Z80 on my TRS-80

[Derision]

Although with this opcode, the pet window comes up and you can control the pet with it, I didn't see the pet's health bar in other group members group window. I'm guessing the code just needs altering to send the OP_Charm packet to all group members.

[MNWatchdog]

Originally Posted by Derision

Although with this opcode, the pet window comes up and you can control the pet with it, I didn't see the pet's health bar in other group members group window. I'm guessing the code just needs altering to send the OP_Charm packet to all group members.

Well Im sure there must be some routine to send updates about specific NPCs, this issue certainly isnt as much of an issue as not being able to buff ones pets if a necro, mage, druid and anyone else Id forgotten.

All pets health bars, summoned or not, arent updated without targetting the pet as it is right now, so most charmers/pet classes have become used to keeping on eye out on their pets health.

Although, feel free to fix these two issues too. heh.

Again, thanks.

[cavedude]

Originally Posted by MNWatchdog

All pets health bars, summoned or not, arent updated without targetting the pet as it is right now, so most charmers/pet classes have become used to keeping on eye out on their pets health.

Although, feel free to fix these two issues too. heh.

Again, thanks.

He already did: http://eqemulator.net/forums/showthread.php?t=25699

[MNWatchdog]

Originally Posted by cavedude

He already did: http://eqemulator.net/forums/showthread.php?t=25699

Cool. Assuming that sends pet health updates to other group members too, that leaves only the update to group members when someone charms/loses charm on a mob.

Good work!

[Angelox]

Originally Posted by Derision

I'm feeling rather proud of myself this morning, I found the OP_Charm opcode for Titanium.

Only this morning? Hell, you're the main reason why I keep coming back to these forums! You always have a very useful fix for all eras - since you like to fix stuff that started back in the older days, it then benefits the classic people and the "live pursuants', or anyone else for that matter.

When I start my daily 'fiddle' with EqEmu , first thing that comes to mind is, "I wonder if Derision has anything new? I think I'll check the forums ..."

If I were still giving out ranks, I would have had to find a new rank for you.

Thank you for the fix!

[So_1337]

That is damned impressive. I've seen so many things on here dismissed as not being feasible, and I'm always so proud to see someone find a way to work it. Fantastic work!

[Angelox]

Originally Posted by So_1337

That is damned impressive. I've seen so many things on here dismissed as not being feasible, and I'm always so proud to see someone find a way to work it. Fantastic work!

It's not really anyones fault, I think there's a reason for this; Roughly, we have two types (in the computer realm) - The Hackers (good hackers!) and the Programmers. A Hacker will try anything regardless of 'if it's supposed to work or not'. Hackers are what made the C64 PC so popular (C64 (Commodore 64) was probably the most hacked PC ever). On the other hand, Programmers follow rules and do not like to depart from that.
In general, Hackers have some knowledge of programming while a good Programmer is highly educated in his area.
The trick is to have a highly educated programmer that likes to hack, and has no qualms about it (hacking, trying anything). Keep in mind, to me, hacking is not a bad word, and it is a main ingredient to a lot of good things that happened in the computing world.
That's why I tried to tell some people, you have to get the fixes posted in ASAP, not worry about if it's perfect. People like Derision obliviously know what they are doing (a highly educated programmer that likes to hack?), and don't need to be oppressed by the useless bureaucracy that has developed here. In fact, I now see other submissions(from other people) that were posted a long time ago and were totally ignored? why? Because someone said it was not going to work?
New stuff needs to get placed in the source, if it doesn't work, well, we all know this is beta (alpha?), it can be taken out again.
But I'm tired trying to get this project to 'rise from the dead'. I finally learned how to add all these submissions myself, to my own source.