Fix for bald players bug

[Angelox]

Ok, I got ya now, I should have searched better.
Thanks for the code BtW

[So_1337]

Seems all the NPCs have white hair now. Is that a result of fixing all the different 0 values? I think we were seeing brown hair as the default on NPCs previously because that's what 0 was getting twisted into. Seems that 0 is actually white hair.

Is that the way you understand it to work?

[Angelox]

Originally Posted by So_1337

Seems all the NPCs have white hair now. Is that a result of fixing all the different 0 values? I think we were seeing brown hair as the default on NPCs previously because that's what 0 was getting twisted into. Seems that 0 is actually white hair.

Is that the way you understand it to work?

it doesn't look like kraeger's fix if you mean the 1120 one

[kraeger]

Angelox is right, it's not my fix that is in the code. I was quite happy to see that a better code had been written, but i will be honest, i am a bit sad after seeing that my name is not in the changelog, at least as part of the team that helped solve the problem, i spent 25+ hours working on this bug..

Anyway:

haircolor 255 = white hairs (when working correctly)
haircolor 0 = dark brown hairs (when working correctly)

I haven't tried 1120 and i don't know what the new fix is in the code, but this what i can understand from what So_1337 is seeing in game:

My fix only affected player characters, this is why we didn't see a change on NPC. From what i understand, the new fix is working on both player and NPC, so we would either need to know what kind of characters it's drawing (Player or NPC) or we would need to update the default NPC model to have brown hair (after the fix).

[So_1337]

I had no idea, my apologies. I saw your fix here and the reports that it was working, then saw that 1120 included a fix for bald players and assumed it to be yours.

Guess we'll have to wait for the full story from KLS. Thanks for the information, guys.

[KLS]

Yeah I'm sorry, but none of your code was used for the fix, I'm not even sure if it's a full fix atm. But you were the inspiration behind it, I'll add you to the log on next update if you'd like.

[kraeger]

None of my code was used so i don't deserve any credit? Well that is kind of rude.

A problem is around for 2-3 years. I find the bug. I write a code that 100% fix it. People test it and it's working. No more bug.

Two days later, a dev comes around and rewrite my code, fixing the same bug but in a different way. (Using all the info i gathered (i said exactly what was not working), taking notes on how i fixed the bug but not using my code, he write his own code.)
The dev code ends up in 1120:
-Breaking all npcs hair colors, they all have white hairs now (my code solved that problem)
-You can't pick the dark brown hair color, it turns white (my code solved that problem)
-You can't pick one beard model, one face model and one eyecolor (my code solved that problem)

Then, he tells me that i don't deserve any credit for "fixing this bug", since none of my code was used. He also tell me that all i was is the inspiration that helped him make his new amazing improved piece of code. Finally, he says that i can have my name written in the next changelog if that can make me happy.. so i shup up and stop talking about it.

If anyone want to say that this is drama, that i am overreacting, that i'm just crying, go ahead.. this is what i'm doing. But right after you post, please re-read what i wrote and ask yourself if i have any reason to feel that way.

Can i remind that dev that right now, i am the only one who made a working fix for this problem.. and i don't deserve any credit?

Is this how things work here?

*Btw, don't add my name to the changelog. I won't be posting on this forum anymore, don't worry.