Combat Fixes

[trevius]

I am glad you weren't upset with my post

I do think that making the code format uniform and cleaning up any compile warnings is awesome. But, if/when you ever decide to do it again, please only do it without making other changes so we know what to expect and what to look for. Making code changes and format changes at the same time makes it too hard to tell what is happening. Probably waiting until the next official release to reformat any files would be a good idea, so we don't have to try to fit the new code changes since the last update in retro-actively. The quicker we can get a new reformat in after a new release, the better.

And on your note about the GetLevel adjustment, are you saying that this code:

  int nBonus = 0;
  int nLevel = GetLevel();

  if(GetClass() == MONK)
    nBonus += 20;
  if(GetLevel() > 50)
    nBonus += 15 * ((nLevel - 45)/5);

Should actually be changed to this:

  int nBonus = 0;
  int nLevel = GetLevel();

  if(GetClass() == MONK)
    nBonus += 20;
  if(nLevel > 50)
    nBonus += 15 * ((nLevel - 45)/5);

and no other changes? Or am I misunderstanding what you are saying?

I can edit that change into your post if I know exactly what you wanted set.

Then we can officially test out the code and get it added

[James76]

Originally Posted by trevius

and no other changes?

Yep, you got it.

[trevius]

Tried to add some of this code to my source tonight and am unable to tell if I need to add in parts of code, replace part, or remove parts.

If you can post something like:

After this:

SomeCode

Add this:

SomeMoreCode

or

Remove this:

SomeCode

And replace it with this:

SomeNewCode

That would make it ALOT easier to get this code added and tested. Sorry about all of the extra work to break it down, but it is still hard to add it in without knowing exactly what is needing to be removed, added, or replaced.

[James76]

Well, I figured if I posted 80 or 100 blocks of one-liner code fields, it would look much more confusing than some simple one-line changes, ... All it takes is to look at the source code, find the line, and change it.

The "riposte and combat math" fixes part, let me eludicate......

342: CHANGE THE LINE

956-969: CHANGE LINES 956-969 WITH THE FOLLOWING

978: CHANGE THE LINE

995: YOU WILL SEE AddToHateList(), insert AvoidDamage() below.

1526: YOU WILL SEE damage=0, insert AvoidDamage() below.

The rest of the changes are simply changes.. I've been holding back any further work until this gets integrated, if this is such a problem maybe I should just wait for CVS access and merge changes myself, if CaveDude EVER gets back to me... This is starting to turn into some kind of joke.

[James76]

Actually, this is clearly becoming too difficult, some simple changes that all it takes is to look at the source code and apply some logic. I could hand this to any of my co-workers, and they have never looked at the source code before, and they wouldn't have any problems I can guarantee you. If they did then they shouldn't have a job as a programmer. So I'm just going to step out of this, no hard feelings, I'm just tired of people passing themselves off as programmers when they aren't, and then I have to justify any little change when I could pass the list of changes to somebody like my project manager and he'd just nod at each line understandingly. An actual team of developers would be flying through changes and code, and instead I feel like any little thing that gets done is always "working against the grain" so-to-speak. I could continue on this path but my foresight is telling me I'm just going to have a lot more of this than necessary, and its just starting to be a complete waste of my time.

[So_1337]

Well, that's the problem, actually. Most of the people here aren't programmers, but they're damn sure doing their best. Add to that the fact that only a handful of people (and up until recently, only two or three people who were active) had any sort of access to the SVN and the ability to commit code, and you wind up with a very slow process.

However, it's now gotten to the point where there is a SVN with many hands working with it at a time. This creates its own issues, as you can imagine, but that's for another post =P The point, though, is that it's only been recent that things have broken open like this in such a way that fixes are really flowing. For those that don't have access (such as yourself, currently), it still requires someone like KLS taking the time to piece through it and putting it in, and she has been severely short on free time lately, if her posts are any indication.

It's very obvious that you have incredible talent, and I'm sorry that the wheels of the project grind so slowly from your perspective. At the same time, though, I've seen more progress in the week and a half that things have moved over to the community SVN than I've seen in a long time. This is the point where it seems that things are finally humming along here.

Everyone contributes of their own free time, and what little of it they can spare. Most of the people here aren't professionals, but most of them do a damn fine job of acting it. Just give a little more patience, if you can. As has been explained, though your fixes are simple to you, they interact with a very large portion of the emulator, one that people are hesitant to tweak without a lot of testing. This isn't any sort of apprehension on their part towards you, just towards the fact that there are so many irons in the fire at the moment.

I'm no one special here, no moderator or anything like that, so don't take my word as gospel. I just know from seeing your contributions that you are quality, and it'd be a shame to see you leave because things haven't moved as fast as you're used to.

Thanks for reading, and for your work.

[erde]

i have applied it to the latest svn. i hope i did everything well.
here is the diff => attack.diff

Please have a look and check this for errors!!

[erde]

Compiles without errors on Linux, but i dont have the time to check this in game :(