A HUGE bug with quest::modifynpcstat

[realityincarnate]

I haven't looked into it much, but I did see that quest::modifynpcstat() does change the maxhp for the mob it's called on. So, based on your description, I'd guess that it's actually a problem with something in the spell handling. It probably pulls a max hp value from the database somewhere.

If you modify an npc and fight it without ever casting a spell, does it work properly? Conversely, does anything other than spells cause it to reset?

[ChaosSlayerZ]

Originally Posted by realityincarnate

I haven't looked into it much, but I did see that quest::modifynpcstat() does change the maxhp for the mob it's called on. So, based on your description, I'd guess that it's actually a problem with something in the spell handling. It probably pulls a max hp value from the database somewhere.

If you modify an npc and fight it without ever casting a spell, does it work properly? Conversely, does anything other than spells cause it to reset?

Yes. if no spells are casted on NPC- and it just fights - as it takes melee dmg, the hps are updated corectly with new max in mind.

So far I cannot tell if anything else can cuase hps to revert other that spells

Note that not just the nukes cause hps to revert- casting a pure Ac buff , or haste or stat buff/debuff - causes the revert of hp to default

[realityincarnate]

Ok, I think I got it. Anytime a spell lands, it recalculates the max hp in case the spell granted any bonuses. The command was directly changing the npc's max hp but not changing the base value that was used in these calculations. I seem to have it fixed in revision 709, but it could probably use some more rigorous testing.

[ChaosSlayerZ]

I need to find time I and finaly update the server rev =)
Thought i will have to wait till next binaries are built.
I will put this into good test, since this little thing is VITAL to one of my custom server features