COMMITTED: Suspend Minion Patch

steve · #1 01-14-2010, 03:22 AM

Those client messages aren't what is used on Live.

blmille2 · #2 01-14-2010, 03:25 AM

You're right. I completely made them up so that I had some idea as to what was going on.

Do you have a link to the client messages?

Thanks!

**KLS** · #3 01-14-2010, 04:34 AM

First of all that's pretty hard to read use the code /code blocks to create a field that will preserve tabs.

Also given that the skill requires staying in the current zone I'm not sold that it needs a database entry or calls. It would in fact be both faster computationally and easier to implement if you created an object in the Client class to store the suspended pet I think.

Also not a fan of the c style functions but that's more stylistic than anything being wrong with them.

blmille2 · #4 01-14-2010, 04:54 AM

Good catch on the no-zone thing. I thought you were able to zone with it after they changed live to allow you to zone and keep your pet.

I'll rework this sometime in the near future and repost (with /code).

Thanks!

P.S. I'll do a search on the accepted coding style here in a bit.