Just went through and added all of the submissions so I can test them out (or rather so Kayen can test them). I noticed that you use line numbers, which is helpful, but in some cases they don't match up with what is on the SVN already. Since things change a lot, it would be good to add in some way to know where to add stuff other than just the line number. That is where the normal diffs come in handy, because they show the surrounding code. If you don't want to do a normal diff, you could just say something like this:
In spell_effects.cpp after this:
Code:
case SE_InterruptCasting:
{
if(IsCasting())
{
if(MakeRandomInt(0, 100) <= spells[spell_id].base[i])
{
InterruptSpell();
}
}
break;
}
Add this:
Code:
case SE_ImprovedSpellEffect:
case SE_BossSpellTrigger:
case SE_CastOnWearoff:
{
if (ticsremaining == 1)
{
SpellOnTarget(spells[spell_id].base[i], this);
}
break;
}
Or here is another example:
In spell_effects.cpp in the DoBuffTic function before this (around line 3299):
Code:
default: {
// do we need to do anyting here?
}
Add this:
Code:
case SE_ImprovedSpellEffect:
case SE_BossSpellTrigger:
case SE_CastOnWearoff:
{
if (ticsremaining == 1)
{
SpellOnTarget(spells[spell_id].base[i], this);
}
break;
}
Not too big of a deal as the line numbers help enough in most cases, but as I was adding your submissions, I found a couple parts kinda hard to tell exactly where you intended them to go. Hopefully I got them in the right places lol.
Threaded Mode
