Did some more playing with it.
Remember how on live, if you had like focus, cast on you by a level 65. Then a level 64 tries to cast focus on you. They would get a reply that the spell would not take hold?
The client handling of updating using this method appears the same. So you will need to probably add some checks for stacking, so that same spells being cast by a lower level, will not take hold.
Its getting closer to working though.
I added a stacking rejection for same spell id's, if new caster level is less than the one whose buff it is. I remember live was like that.
There were also issues with durations too. Probably don't want to overwrite if new one has a shorter duration, like from less focus effects or duration enhancing AAs.
Update: Duration of new buff, has no effect, on whether the client will allow overwriting. Only the level of the caster of the new buff, if it is lower than the level of the caster of the existing buff.
In CheckStackConflict, I added:
Code:
if(spellid1 == spellid2 && caster_level2 < caster_level1) {
mlog(SPELLS__STACKING, "Blocking same spell because new caster level is less than level of existing buff");
return -1;
}
Works great now, and has that annoying effect of not taking hold, if you are lower level than one who orginally cast.
I remember with debuffs the effect especially, after a new expansion came out, and a debuff was landed by someone at a higher level. Then noone could refresh that buff, like malo, unless they were same level or higher.
Haynar
Threaded Mode
