Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Development

Development::Development Forum for development topics and for those interested in EQEMu development. (Not a support forum)

Reply
 
Thread Tools Display Modes
  #1  
Old 02-28-2013, 09:49 PM
lerxst2112
Demi-God
 
Join Date: Aug 2010
Posts: 1,742
Default

Changing from tabs to spaces or the reverse can be a lot of fun with merges if your preferred diff program doesn't properly ignore whitespace/line endings.

http://www.hanselman.com/blog/YoureJ...InTheWall.aspx


The best standards are simple and lightweight, otherwise people just won't follow them, even at a professional job. Most of the ones I've written are 10 or fewer bullet points and all of the formatting issues are things that you can easily do with astyle or another formatting utility so that even if people prefer to work a different way they can easily make their code conformant before they check it in.

My personal preference has always been to use 4 spaces for an indent, but I'm fine with tabs too. In fact, tabs might be better for those mildly insane individuals that like 2 character indents, or the ones that were dropped on their heads repeatedly as children that use proportional fonts.
Reply With Quote
  #2  
Old 02-28-2013, 10:57 PM
Akkadius's Avatar
Akkadius
Administrator
 
Join Date: Feb 2009
Location: MN
Posts: 2,072
Default

Quote:
Originally Posted by lerxst2112 View Post
Changing from tabs to spaces or the reverse can be a lot of fun with merges if your preferred diff program doesn't properly ignore whitespace/line endings.

http://www.hanselman.com/blog/YoureJ...InTheWall.aspx


The best standards are simple and lightweight, otherwise people just won't follow them, even at a professional job. Most of the ones I've written are 10 or fewer bullet points and all of the formatting issues are things that you can easily do with astyle or another formatting utility so that even if people prefer to work a different way they can easily make their code conformant before they check it in.

My personal preference has always been to use 4 spaces for an indent, but I'm fine with tabs too. In fact, tabs might be better for those mildly insane individuals that like 2 character indents, or the ones that were dropped on their heads repeatedly as children that use proportional fonts.
You always make me laugh.

I always use tabs and never spaces, that could be false for some of my really old stuff.

There are programs or scripts that can be gone through the source that will beautify things but really there just needs to be practices defined in the Github.

It hasn't been a problem really with SVN because the individuals that could commit were already proven to have a somewhat decent methodology. If they didn't, they got torn up in IRC or on threads.

KLS has the most professional opinion as to standards and practices not only due to the massive experience on the Emulator but 4+ years of specialized computer science/programming that only seasoned the raw skill KLS had before and during.

Trevius has also policed our practices on emulator such as how Perl exported objects are named in quest:: and $entity-> objects for example. quest::allbeinglowercase() and $entity->HavingWordsCapitalized(); are just a few small examples.

Standards and guidelines aren't bad to have, but as always they have to be enforced and kept up upon and we've done a decent job of policing that amongst ourselves but it is a different story with anyone being able to fork to the Github now, so it wouldn't be a bad idea.
Reply With Quote
  #3  
Old 03-01-2013, 12:28 AM
demonstar55
Demi-God
 
Join Date: Apr 2008
Location: MA
Posts: 1,164
Default

Most simple indent policy would be just don't mix tabs and spaces, ever. Then a Dev can use tabs if they want or spaces. Plus it is better for tools to convert.
Reply With Quote
  #4  
Old 03-01-2013, 01:18 AM
KLS
Administrator
 
Join Date: Sep 2006
Posts: 1,348
Default

I knew a guy in college who did 3 space indents, cause 2 was too few and 4 was too many. Hated reading his code, cause it was just utterly bizarre trying to line it up.

I don't intend to do complicated standards.
-We need to standardize our naming conventions (especially for things like files).
-Stop mixing tabs and spaces no matter which way we go.
-I'd like to limit line length to something, maybe not a hard limit and probably a bit more than 80 characters. Its just that it sucks reading lines that are 780 characters long cause someone couldn't be bothered to break a string up.
-There's a few practices with regard to the actual coding that would be nice to clarify how it should be done rather than keep answering questions or correcting people who do it wrong.
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 01:28 AM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2025, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3