Yes, I thought I did a diff against the fetch but I messed that up. I just did the merge now and am testing the code that was submitted already.
But, I expect to see erudnext fail regardless... processing..
- My change mentioned above to add methods of IsWater, IsLiquid, etc to the water_map_v1.h file that matched the 1 argument zyz_location fixed something. Prior to the fix, #bestz never detected water in a v1 map. After the fix, other zones like erudsxwing detected the water with #bestz. Before the fix, zero water mobs attacked me - after the fix sharks in erudsxing do attack me, while mobs in erudnext ocean do not.
This leads me to think the erudnext water map is bad or incomplete.
posting results with up-to-date code shortly.
|
Threaded Mode
