Acceptable/efficient syntax

[AdrianD]

I removed the Spellshield and the "cast on other" messages which appear when attacking an npc with a rune. The Spellshield message seemed correct but, the "cast on other" message displays the damage shield "cast on other" each time the npc hits the client. This only occurs if the client has a DS and the NPC has a rune. The "was pierced by thorns" message also appears, as normal.

My main concern is if the second line I commented out will affect anything else. I tested this by casting a rune on myself and having an npc attack and dispel the rune. It appears to work normal. I left larger spaces between lines to accentuate the lines I commented out.

\zone\attack.cpp(3548 - 3571)

//see if any runes want to reduce this damage
if(spell_id == SPELL_UNKNOWN) {
	damage = ReduceDamage(damage);
	Log.Out(Logs::Detail, Logs::Combat, "Melee Damage reduced to %d", damage);
	damage = ReduceAllDamage(damage);
	TryTriggerThreshHold(damage, SE_TriggerMeleeThreshold, attacker);

        if (skill_used)
		CheckNumHitsRemaining(NumHit::IncomingHitSuccess);

} else {
	int32 origdmg = damage;
	
	
//	damage = AffectMagicalDamage(damage, spell_id, iBuffTic, attacker); <--- commented out second


/*	if (origdmg != damage && attacker && attacker->IsClient()) {  <---
		if(attacker->CastToClient()->GetFilter(FilterDamageShields) != FilterHide)  <--- commented out first
			attacker->Message(15, "The Spellshield absorbed %d of %d points of damage", origdmg - damage, origdmg);  <---
	} */
			
			
	if (damage == 0 && attacker && origdmg != damage && IsClient()) {
		//Kayen: Probably need to add a filter for this - Not sure if this msg is correct but there should be a message for spell negate/runes.
		Message(263, "%s tries to cast on YOU, but YOUR magical skin absorbs the spell.",attacker->GetCleanName());
	}
	damage = ReduceAllDamage(damage);
	TryTriggerThreshHold(damage, SE_TriggerSpellThreshold, attacker);
}

I was trying to find the relationship in this portion with other portions that would tell me why it would make the reference to `cast_on_other` but, couldn't figure it out.

Thanks