Incorrect faction ID: Freeport Monk Guild

[DarkSanto]

Not sure where to go to submit a bug on this, because god knows I should not be allowed to submit any kind of pull request to any repo on the planet, but as I've been revisiting The Good Old Days, I discovered my monk was still Indifferent to the Freeport Monk GM, which meant I couldn't start the sash quest line as part of the (eventual) journey towards doing the monk epic.

Looking thru the database I saw that the Faction ID for all the Freeport Monk GMs was id 305, which is "Rogues of the White Rose" in faction_list.

I set their faction IDs to 361 which is Ashen Order.

[DarkSanto]

Replying to myself: the 305/361 was a red herring, I misread npc_faction versus faction_id. BUT! Velan the guildmaster had his faction ID set to 0, so that looks like (one of) the problems in the game data. I'm wondering if anyone else has run into this.

[DarkSanto]

One more reply for any other newbies: The reason Velan Torresk isn't responding to hails is because for whatever reason, there are two separate npc_types entries for Velan Torresk:

Velan_Torresk
Brother_Velan_Torresk

The lua for him was Velan_Torresk, but the mob that spawns in the westfreeport zone is Brother_Velan_Torresk. Copying the quest lua and adding Brother_ to the front of the name got the quest working.