Just a quick note on the pet hp in spells.cpp

[Sandabus]

I don't know if anyone has noticed this before...I was just perusing
the spells.cpp and I noticed that there appears to be a
'break' statement missing from the warrior class of pets.
I checked the 0.4.4DR release and it's missing from there
(approximately line number 5906)
I could be wrong and this might be the intended behavior for that switch statement
(been eons since i've done any serious c programming)
But the other classes all had break statements so I'm leaning towards the belief
that there might be a typo here.


Sandabus - Da Ganomie Archon (still searching for a DB that works *sigh*)

[fnemo]

didnt read this part of the code yet. what is the next statement ?

[Sandabus]

Hmmm Look in spells.cpp and do a search for WARRIOR
(I've noticed the line numbers change signifigantly from
release to release).
There's an entire section with a switch statement that tells
which multiplier to use for a pet's hps.
(Use all caps on the WARRIOR search btw).
It's in the function
sint32 Mob::CalcPetHp

If that narrows it down any better (actual line numbers seem to
change from release to release so not that accurate I spose)

Sandabus - Da Ganomie Archon
(Still trying to get his GM status to work properly!! Time to reload the DB!!)

[Trumpcard]

sint32 base_hp = 0;
switch(classb) {
case WARRIOR:
if (levelb < 20)
multiplier = 22;
else if (levelb < 30)
multiplier = 23;
else if (levelb < 40)
multiplier = 25;
else if (levelb < 53)
multiplier = 27;
else if (levelb < 57)
multiplier = 28;
else
multiplier = 30;
case DRUID:



I'd guess that its falling through to the default: case since the break is missing..

I'll fix it tonight in CVS

[Sandabus]

Yep. That's what it looked like to me.
No biggee of course....a couple less on the multiplier at worst.
My C is so rusty I barely caught it

Sandabus - Da Ganomie Archon