Magician pet heals

Tigatupa · #1 08-13-2006, 09:36 PM

Magican pet heal remove buffs, such as - Burnout and DS .. Was wondering if that what it's supposed to do ??

Zengez · #2 08-13-2006, 10:45 PM

I have the same problem on my server with all buffs, and no, it's not suppose to do that

Magoth78 · #3 08-16-2006, 10:28 AM

This post should be moved to Bug reports.

There is a code fix:

spells_effects.cpp, line 1326

change:

Code:

if (effect_value >= buffs[j].poisoncounters){

to:

Code:

if (buffs[j].poisoncounters>0 && effect_value >= buffs[j].poisoncounters) {

Mag

**fathernitwit** · #4 08-16-2006, 01:20 PM

are you suggesting that the buffs which are being stripped off have negative poison counters?

as the previous line:
if (buffs[j].poisoncounters == 0)
skips anything with 0 poison counters...

Magoth78 · #5 08-16-2006, 09:41 PM

Hello fathernitwit,

Doodman helped me on this one and, since, it seems to work, atleast for me.

As this bug was totally random, I think that sometimes the poisoncounter on a buff is updated even it doesn't have any poisoncounter base.

Like you said:
if (buffs[j].poisoncounters == 0) // skips anything with 0 poison counters. I've made some tests and didn't see the pet heal spells dispelling a buff the first time the heal is casted.

When the bug occurs.. it matches with the next statement:
if (effect_value >= buffs[j].poisoncounters) {

The effect_value is -10 for the pet's heal spell, so if the statement isn't matched the first time I cast the spell but after (and still randomly), that means the poisoncounters on the buff has been updated, signed. Am I right?

Now, why is the buff.poisoncounters is updated whereas the buff hasn't any poisoncounter base ? I don't know but I'm actually trying to find this out.

Mag

**fathernitwit** · #6 08-20-2006, 04:28 AM

hmm... you might be on to something.. I just made a quick change to zero out the counter fields in a buff slot when we put a new spell into it, please test it and report back.