Memming Spell Sets: bug and fix

[number6]

At the moment, if you have no memmed spells at all, then loading a spell set from the client UI works. But, it doesn't un-mem spells first. I've added code for OP_LoadSpellSet to simply unmem all spells first, and it works. It seems the client deals with handling the sequential memming of the spells, presumably so the user can interrupt it, so that turned out to be an easy one. It works fine for me with the titanium client, can't test with any other.

** edit: It's been pointed out by one of my players that this still doesn't quite mimic "live" behaviour, which apparently only un-mems spells that are about to change, thus speeding things up. Sorry - but I think this is a reasonable halfway house, I don't know how to parse the contents of the EQApplicationPacket.

Cheers, Paul.

*** ../../EQEmu-0.7.0-903/zone/client_packet.h 2006-08-15 02:18:33.000000000 +0100
--- client_packet.h 2006-11-13 11:17:23.000000000 +0000
***************
*** 207,210 ****
--- 207,211 ----
void Handle_OP_RequestTitles(const EQApplicationPacket *app);
void Handle_OP_PurchaseLeadershipAA(const EQApplicationPacket *app);
void Handle_OP_Ignore(const EQApplicationPacket *app);
+ void Handle_OP_LoadSpellSet(const EQApplicationPacket *app);

*** ../../EQEmu-0.7.0-903/zone/client_packet.cpp 2006-10-31 03:04:23.000000000 +0000
--- client_packet.cpp 2006-11-13 11:24:08.000000000 +0000
***************
*** 307,312 ****
--- 307,313 ----
ConnectedOpcodes[OP_SenseHeading] = &Client::Handle_OP_Ignore;
ConnectedOpcodes[OP_FloatListThing] = &Client::Handle_OP_Ignore;
ConnectedOpcodes[OP_WorldUnknown001] = &Client::Handle_OP_Ignore;
+ ConnectedOpcodes[OP_LoadSpellSet] = &Client::Handle_OP_LoadSpellSet;

}

***************
*** 4393,4398 ****
--- 4394,4406 ----
return;
}

+ void Client::Handle_OP_LoadSpellSet(const EQApplicationPacket *app)
+ {
+ Client::UnmemSpellAll(true);
+ return;
+ }
+
+
void Client::Handle_OP_PetitionBug(const EQApplicationPacket *app)
{
if(app->size!=sizeof(PetitionBug_Struct))