quest::setanim bug, known or not?

nightsta69 · #1 10-21-2009, 02:46 PM

somethin I found out while working on my tutorial zone,

Code:

quest::setanim(npcID,3);

causes zone.exe crashes if it is placed in an NPC pl. is this known, and is there a fix for it? I have it placed in sub EVENT_SPAWN. so when the NPC spawns, its spawns lying down, like its passed out, but as soon as it spawns, zone crashes.

**trevius** · #2 10-21-2009, 04:09 PM

Previously, you had to set a timer before changing the animation to make them lay down like this:

Code:

sub EVENT_SPAWN {

	quest::settimer("sleep",5);

}

sub EVENT_TIMER {

	if ($timer eq "sleep") {
		quest::stoptimer("sleep");
		$npc->SetAppearance(0);
		$npc->SetAppearance(3);
		quest::settimer("sleep",300);
	}

}

But, I think this should work for it now:

Code:

sub EVENT_SPAWN {

	$npc->SetAppearance(3);

}

I am not aware of any crashes like you explained, but maybe there was something you did wrong, I dunno. At least one of these ways should work out for you. The reason the timer one is set to repeat is because we previously did not send out appearance packets for animations for new people zoning in, so you would have to set the appearance repeatedly so new players zoning in could see it.

**Shin Noir** · #3 10-21-2009, 04:31 PM

Hmm.
void QuestManager::setanim(int npc_type, int animnum) {
//Cisyouc: adds appearance changes
Mob* thenpc = entity_list.GetMobByNpcTypeID(npc_type);
if(animnum < 0 || animnum >= _eaMaxAppearance)
return;
thenpc->SetAppearance(EmuAppearance(animnum));
}
There's no checking to ensure the mob is valid before setting the appearance.